Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better encapsulation for the anomaly demo #181

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Conversation

razvan
Copy link
Member

@razvan razvan commented Mar 19, 2025

  • fix: better encapsulation for the anomaly detection stack
  • remove unused dependency

@razvan razvan self-assigned this Mar 19, 2025
@razvan razvan requested a review from a team March 19, 2025 13:20
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't consider this a fix but LGTM :P

@razvan
Copy link
Member Author

razvan commented Mar 19, 2025

I wouldn't consider this a fix but LGTM :P

Thanks.

Indeed, the actual fix is not obvious, but that I think, proves the point. The actual fix is that the minio hostname must be fully qualified for demos that use the redered minio chart with tls.

@razvan razvan added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 2ee7cf0 Mar 19, 2025
2 checks passed
@razvan razvan deleted the fix/anomaly-details branch March 19, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants